-
Notifications
You must be signed in to change notification settings - Fork 85
Feature / RadioRichButtons #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| options: { | ||
| label: ReactNode; | ||
| hintText?: ReactNode; | ||
| nativeInputProps: ComponentProps<"input">; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it's best to use the ComponetProps type helper from React.
|
Hey @enguerranws, Thanks a lot for the PR! I first I did this review to improve consistency with the rest of the project: 765f233 But in the end I did even simpler. I don't think we need to have a separate RadiRichButton. We can just infer it's rich by the use of illustations. |
I thought about that, but I wanted to stick the DSFR's components (where Radio buttons and Radio rich are presented as different components), but that's fine for me! |
Oh! Is that so? In that case you probably made the right call. |
|
I can rollback the last commit if you think it's best. Idk |
Todo: